No subject


Mon Nov 3 13:03:41 PST 2008


libshout uses general _WIN32 preprocessor check, but assumes that
it means Microsoft's cl.exe compiler - that it not true. Only the
presence of _MSC_VER points to that, _WIN32 may be (and is) defined by
MinGW, which (being C99- and *nix-compatible) does not need some of
the definitions that libshout does for cl.exe


Modified: icecast/trunk/libshout/include/os.h
===================================================================
--- icecast/trunk/libshout/include/os.h	2009-06-23 17:23:08 UTC (rev 16174)
+++ icecast/trunk/libshout/include/os.h	2009-06-23 17:25:55 UTC (rev 16175)
@@ -1,4 +1,4 @@
-#ifdef _WIN32
+#ifdef _MSC_VER
 typedef __int64 int64_t;
 typedef unsigned __int64 uint64_t;
 typedef unsigned __int32 uint32_t;

Modified: icecast/trunk/libshout/src/shout.c
===================================================================
--- icecast/trunk/libshout/src/shout.c	2009-06-23 17:23:08 UTC (rev 16174)
+++ icecast/trunk/libshout/src/shout.c	2009-06-23 17:25:55 UTC (rev 16175)
@@ -38,7 +38,7 @@
 #include "shout_private.h"
 #include "util.h"
 
-#ifdef _WIN32
+#ifdef _MSC_VER
 # ifndef va_copy
 #  define va_copy(ap1, ap2) memcpy(&ap1, &ap2, sizeof(va_list))
 # endif



More information about the commits mailing list