[xiph-commits] r14562 - trunk/vorbis-tools/oggenc

ivo at svn.xiph.org ivo at svn.xiph.org
Sun Mar 9 15:31:47 PDT 2008


Author: ivo
Date: 2008-03-09 15:31:47 -0700 (Sun, 09 Mar 2008)
New Revision: 14562

Modified:
   trunk/vorbis-tools/oggenc/oggenc.c
Log:
"Comparing string pointers is not a good way to find out if the strings are identical."

Modified: trunk/vorbis-tools/oggenc/oggenc.c
===================================================================
--- trunk/vorbis-tools/oggenc/oggenc.c	2008-03-09 21:40:08 UTC (rev 14561)
+++ trunk/vorbis-tools/oggenc/oggenc.c	2008-03-09 22:31:47 UTC (rev 14562)
@@ -771,8 +771,8 @@
                 opt->namefmt = strdup(optarg);
                 break;
             case 'X':
-                if(opt->namefmt_remove && opt->namefmt_remove != 
-                        DEFAULT_NAMEFMT_REMOVE)
+                if(opt->namefmt_remove && strcmp(opt->namefmt_remove,
+                       DEFAULT_NAMEFMT_REMOVE))
                 {
                     fprintf(stderr, _("WARNING: Multiple name format filters specified, using final\n"));
                     free(opt->namefmt_remove);
@@ -947,7 +947,7 @@
         else
             i = filenum;
 
-        *album = opt->album[i];    
+        *album = opt->album[i];
         add_tag(vc, opt, "album", opt->album[i]);
     }
 



More information about the commits mailing list