[xiph-commits] r14719 - trunk/theora/lib/dec

tterribe at svn.xiph.org tterribe at svn.xiph.org
Sat Apr 12 04:36:41 PDT 2008


Author: tterribe
Date: 2008-04-12 04:36:40 -0700 (Sat, 12 Apr 2008)
New Revision: 14719

Modified:
   trunk/theora/lib/dec/decinfo.c
Log:
Actually compare in the correct direction when testing comment buffer size.


Modified: trunk/theora/lib/dec/decinfo.c
===================================================================
--- trunk/theora/lib/dec/decinfo.c	2008-04-12 08:36:58 UTC (rev 14718)
+++ trunk/theora/lib/dec/decinfo.c	2008-04-12 11:36:40 UTC (rev 14719)
@@ -117,7 +117,7 @@
   /*Read the user comments.*/
   _tc->comments=(int)oc_unpack_length(_opb);
   if(_tc->comments<0||_tc->comments>(LONG_MAX>>2)||
-   theorapackB_bytes(_opb)+((long)_tc->comments<<2)<=_opb->storage){
+   theorapackB_bytes(_opb)+((long)_tc->comments<<2)>_opb->storage){
     return TH_EBADHEADER;
   }
   _tc->comment_lengths=(int *)_ogg_malloc(



More information about the commits mailing list