[xiph-commits] r13909 - trunk/theora/lib/dec

tterribe at svn.xiph.org tterribe at svn.xiph.org
Thu Sep 27 18:36:41 PDT 2007


Author: tterribe
Date: 2007-09-27 18:36:41 -0700 (Thu, 27 Sep 2007)
New Revision: 13909

Modified:
   trunk/theora/lib/dec/state.c
Log:
Fix long-standing bug in the umv padding code that left the first 8 to 16 bytes
 of the first row in the full reconstruction buffer uninitialized (and also
 wrote 8 bytes past the end of the buffer, not that valgrind ever complained).


Modified: trunk/theora/lib/dec/state.c
===================================================================
--- trunk/theora/lib/dec/state.c	2007-09-28 00:54:01 UTC (rev 13908)
+++ trunk/theora/lib/dec/state.c	2007-09-28 01:36:41 UTC (rev 13909)
@@ -638,7 +638,7 @@
   iplane=_state->ref_frame_bufs[_refi]+_pli;
   fullw=iplane->width+(hpadding<<1);
   apix=iplane->data-hpadding;
-  bpix=iplane->data+(iplane->height-1)*iplane->ystride;
+  bpix=iplane->data+(iplane->height-1)*iplane->ystride-hpadding;
   epix=apix-iplane->ystride*vpadding;
   while(apix!=epix){
     memcpy(apix-iplane->ystride,apix,fullw);



More information about the commits mailing list