[xiph-commits] r13798 - icecast/trunk/icecast/src

karl at svn.xiph.org karl at svn.xiph.org
Thu Sep 13 20:01:18 PDT 2007


Author: karl
Date: 2007-09-13 20:01:17 -0700 (Thu, 13 Sep 2007)
New Revision: 13798

Modified:
   icecast/trunk/icecast/src/admin.c
   icecast/trunk/icecast/src/format_vorbis.c
Log:
small build fix and a minor issue highlighted by coverity


Modified: icecast/trunk/icecast/src/admin.c
===================================================================
--- icecast/trunk/icecast/src/admin.c	2007-09-13 23:29:43 UTC (rev 13797)
+++ icecast/trunk/icecast/src/admin.c	2007-09-14 03:01:17 UTC (rev 13798)
@@ -1005,8 +1005,9 @@
     }
     else
     {
+        xmlDocPtr doc;
         avl_tree_rlock (global.source_tree);
-        xmlDocPtr doc = admin_build_sourcelist(NULL);
+        doc = admin_build_sourcelist(NULL);
         avl_tree_unlock (global.source_tree);
 
         admin_send_response(doc, client, response, 

Modified: icecast/trunk/icecast/src/format_vorbis.c
===================================================================
--- icecast/trunk/icecast/src/format_vorbis.c	2007-09-13 23:29:43 UTC (rev 13797)
+++ icecast/trunk/icecast/src/format_vorbis.c	2007-09-14 03:01:17 UTC (rev 13798)
@@ -440,13 +440,13 @@
         ogg_info->artist = value;
         change = 1;
     }
-    if (strcmp (tag, "title") == 0)
+    else if (strcmp (tag, "title") == 0)
     {
         free (ogg_info->title);
         ogg_info->title = value;
         change = 1;
     }
-    if (strcmp (tag, "song") == 0)
+    else if (strcmp (tag, "song") == 0)
     {
         free (ogg_info->artist);
         free (ogg_info->title);



More information about the commits mailing list