[xiph-commits] r10279 - in branches/oggdsf_new_demux/src/lib: codecs/vorbis/filters/dsfVorbisDecoder core/directshow/dsfOggDemux2

[illiminable at svn.xiph.org]

Author: illiminable
Date: 2005-10-23 10:40:31 -0700 (Sun, 23 Oct 2005)
New Revision: 10279

Modified:
   branches/oggdsf_new_demux/src/lib/codecs/vorbis/filters/dsfVorbisDecoder/VorbisDecodeInputPin.cpp
   branches/oggdsf_new_demux/src/lib/core/directshow/dsfOggDemux2/OggDemuxPacketSourcePin.cpp
   branches/oggdsf_new_demux/src/lib/core/directshow/dsfOggDemux2/OggStreamMapper.cpp
Log:
* Remove COM memory leak
* Don't addref IOggDecoder since it's not a true COM interface

Modified: branches/oggdsf_new_demux/src/lib/codecs/vorbis/filters/dsfVorbisDecoder/VorbisDecodeInputPin.cpp
===================================================================
--- branches/oggdsf_new_demux/src/lib/codecs/vorbis/filters/dsfVorbisDecoder/VorbisDecodeInputPin.cpp	2005-10-23 17:12:57 UTC (rev 10278)
+++ branches/oggdsf_new_demux/src/lib/codecs/vorbis/filters/dsfVorbisDecoder/VorbisDecodeInputPin.cpp	2005-10-23 17:40:31 UTC (rev 10279)
@@ -80,7 +80,7 @@
 		return NOERROR;
 	} else if (riid == IID_IOggDecoder) {
 		*ppv = (IOggDecoder*)this;
-		((IUnknown*)*ppv)->AddRef();
+		//((IUnknown*)*ppv)->AddRef();
 		return NOERROR;
 
 	}

Modified: branches/oggdsf_new_demux/src/lib/core/directshow/dsfOggDemux2/OggDemuxPacketSourcePin.cpp
===================================================================
--- branches/oggdsf_new_demux/src/lib/core/directshow/dsfOggDemux2/OggDemuxPacketSourcePin.cpp	2005-10-23 17:12:57 UTC (rev 10278)
+++ branches/oggdsf_new_demux/src/lib/core/directshow/dsfOggDemux2/OggDemuxPacketSourcePin.cpp	2005-10-23 17:40:31 UTC (rev 10279)
@@ -60,6 +60,8 @@
 	//delete[] mBOSAsFormatBlock;
 	//delete mBOSPage;
 	delete mIdentHeader;
+
+
 }
 
 bool OggDemuxPacketSourcePin::acceptOggPage(OggPage* inOggPage)

Modified: branches/oggdsf_new_demux/src/lib/core/directshow/dsfOggDemux2/OggStreamMapper.cpp
===================================================================
--- branches/oggdsf_new_demux/src/lib/core/directshow/dsfOggDemux2/OggStreamMapper.cpp	2005-10-23 17:12:57 UTC (rev 10278)
+++ branches/oggdsf_new_demux/src/lib/core/directshow/dsfOggDemux2/OggStreamMapper.cpp	2005-10-23 17:40:31 UTC (rev 10279)
@@ -10,6 +10,9 @@
 
 OggStreamMapper::~OggStreamMapper(void)
 {
+	for (size_t i = 0; i < mPins.size(); i++) {
+		delete mPins[i];
+	}
 }
 OggDemuxPacketSourcePin* OggStreamMapper::getPinByIndex(unsigned long inIndex)
 {