[xiph-commits] r8663 - in trunk/oggdsf/src/lib: codecs/flac/libs/libFLACHelper core/ogg/libOOOggSeek

[illiminable at motherfish-iii.xiph.org]

Author: illiminable
Date: 2005-01-07 08:33:57 -0800 (Fri, 07 Jan 2005)
New Revision: 8663

Modified:
   trunk/oggdsf/src/lib/codecs/flac/libs/libFLACHelper/FLACHeaderTweaker.cpp
   trunk/oggdsf/src/lib/core/ogg/libOOOggSeek/AutoOggSeekTable.cpp
   trunk/oggdsf/src/lib/core/ogg/libOOOggSeek/libOOOggSeek.vcproj
Log:
* libOOOggSeek now 0 warnings
* Mark a warning that needs to be checked in flachelper.

Modified: trunk/oggdsf/src/lib/codecs/flac/libs/libFLACHelper/FLACHeaderTweaker.cpp
===================================================================
--- trunk/oggdsf/src/lib/codecs/flac/libs/libFLACHelper/FLACHeaderTweaker.cpp	2005-01-07 16:25:35 UTC (rev 8662)
+++ trunk/oggdsf/src/lib/codecs/flac/libs/libFLACHelper/FLACHeaderTweaker.cpp	2005-01-07 16:33:57 UTC (rev 8663)
@@ -98,7 +98,7 @@
 	locFirstPackBuff[6] = 0;
 	locFirstPackBuff[7] = 0; //Num header HIGH BYTE
 
-	//*** VERIFY ::: Is this even safe ????
+	//*** VERIFY ::: Is this even safe ie -2 ... are we sure this can't go negative ????
 	locFirstPackBuff[8] = mOldHeaderList.size() - 2; //Num headers LOW BYTE
 	locFirstPackBuff[9] = 'f';
 	locFirstPackBuff[10] = 'L';

Modified: trunk/oggdsf/src/lib/core/ogg/libOOOggSeek/AutoOggSeekTable.cpp
===================================================================
--- trunk/oggdsf/src/lib/core/ogg/libOOOggSeek/AutoOggSeekTable.cpp	2005-01-07 16:25:35 UTC (rev 8662)
+++ trunk/oggdsf/src/lib/core/ogg/libOOOggSeek/AutoOggSeekTable.cpp	2005-01-07 16:33:57 UTC (rev 8663)
@@ -249,13 +249,13 @@
 bool AutoOggSeekTable::serialiseInto(const string inSeekTableFilename)
 {
 	unsigned long locSerialisedSeekTableSize = serialisedSize();
-	unsigned char *locBuffer = new unsigned char[serialisedSize()];
+	unsigned char *locBuffer = new unsigned char[locSerialisedSeekTableSize];
 
-	if (serialiseInto(locBuffer, serialisedSize())) {
+	if (serialiseInto(locBuffer, locSerialisedSeekTableSize)) {
 		fstream locOutputFile;
 
 		locOutputFile.open(inSeekTableFilename.c_str(), ios_base::out | ios_base::binary);
-		locOutputFile.write((char*)locBuffer, serialisedSize());
+		locOutputFile.write((char*)locBuffer, locSerialisedSeekTableSize);
 		locOutputFile.close();
 	} else {
 		delete [] locBuffer;

Modified: trunk/oggdsf/src/lib/core/ogg/libOOOggSeek/libOOOggSeek.vcproj
===================================================================
--- trunk/oggdsf/src/lib/core/ogg/libOOOggSeek/libOOOggSeek.vcproj	2005-01-07 16:25:35 UTC (rev 8662)
+++ trunk/oggdsf/src/lib/core/ogg/libOOOggSeek/libOOOggSeek.vcproj	2005-01-07 16:33:57 UTC (rev 8663)
@@ -28,7 +28,8 @@
 				WarningLevel="4"
 				Detect64BitPortabilityProblems="TRUE"
 				DebugInformationFormat="4"
-				CallingConvention="2"/>
+				CallingConvention="2"
+				DisableSpecificWarnings="4251"/>
 			<Tool
 				Name="VCCustomBuildTool"/>
 			<Tool
@@ -86,7 +87,8 @@
 				WarningLevel="4"
 				Detect64BitPortabilityProblems="TRUE"
 				DebugInformationFormat="0"
-				CallingConvention="2"/>
+				CallingConvention="2"
+				DisableSpecificWarnings="4251"/>
 			<Tool
 				Name="VCCustomBuildTool"/>
 			<Tool
@@ -147,7 +149,8 @@
 				WarningLevel="4"
 				Detect64BitPortabilityProblems="TRUE"
 				DebugInformationFormat="0"
-				CallingConvention="2"/>
+				CallingConvention="2"
+				DisableSpecificWarnings="4251"/>
 			<Tool
 				Name="VCCustomBuildTool"/>
 			<Tool
@@ -208,7 +211,8 @@
 				WarningLevel="4"
 				Detect64BitPortabilityProblems="TRUE"
 				DebugInformationFormat="0"
-				CallingConvention="2"/>
+				CallingConvention="2"
+				DisableSpecificWarnings="4251"/>
 			<Tool
 				Name="VCCustomBuildTool"/>
 			<Tool
@@ -261,7 +265,8 @@
 				WarningLevel="4"
 				Detect64BitPortabilityProblems="TRUE"
 				DebugInformationFormat="4"
-				CallingConvention="0"/>
+				CallingConvention="0"
+				DisableSpecificWarnings="4251"/>
 			<Tool
 				Name="VCCustomBuildTool"/>
 			<Tool
@@ -319,7 +324,8 @@
 				WarningLevel="4"
 				Detect64BitPortabilityProblems="TRUE"
 				DebugInformationFormat="0"
-				CallingConvention="0"/>
+				CallingConvention="0"
+				DisableSpecificWarnings="4251"/>
 			<Tool
 				Name="VCCustomBuildTool"/>
 			<Tool