[xiph-commits] r8240 - in trunk/oggdsf/src/lib/core: directshow/dsfOggDemux ogg/libOOOgg

illiminable at motherfish-iii.xiph.org illiminable at motherfish-iii.xiph.org
Sat Nov 20 22:47:54 PST 2004


Author: illiminable
Date: 2004-11-20 22:47:53 -0800 (Sat, 20 Nov 2004)
New Revision: 8240

Modified:
   trunk/oggdsf/src/lib/core/directshow/dsfOggDemux/IFilterDataSource.h
   trunk/oggdsf/src/lib/core/ogg/libOOOgg/IFIFOBuffer.h
   trunk/oggdsf/src/lib/core/ogg/libOOOgg/INotifyArrival.h
   trunk/oggdsf/src/lib/core/ogg/libOOOgg/INotifyComplete.h
   trunk/oggdsf/src/lib/core/ogg/libOOOgg/IOggCallback.h
   trunk/oggdsf/src/lib/core/ogg/libOOOgg/IOggPackSource.h
   trunk/oggdsf/src/lib/core/ogg/libOOOgg/IStampedOggPacketSink.h
Log:
* Added explicit empty virtual destructors to interfaces to ensure proper destruction

Modified: trunk/oggdsf/src/lib/core/directshow/dsfOggDemux/IFilterDataSource.h
===================================================================
--- trunk/oggdsf/src/lib/core/directshow/dsfOggDemux/IFilterDataSource.h	2004-11-21 06:06:19 UTC (rev 8239)
+++ trunk/oggdsf/src/lib/core/directshow/dsfOggDemux/IFilterDataSource.h	2004-11-21 06:47:53 UTC (rev 8240)
@@ -34,6 +34,10 @@
 class OGG_DEMUX_API IFilterDataSource
 {
 public:
+	//Empty Constructor and destructor to ensure proper deletion
+	IFilterDataSource(void)							{}
+	virtual ~IFilterDataSource(void)				{}
+
 	virtual unsigned long seek(unsigned long inPos) = 0;
 	virtual void close()  = 0;
 	virtual bool open(string inSourceLocation) = 0;

Modified: trunk/oggdsf/src/lib/core/ogg/libOOOgg/IFIFOBuffer.h
===================================================================
--- trunk/oggdsf/src/lib/core/ogg/libOOOgg/IFIFOBuffer.h	2004-11-21 06:06:19 UTC (rev 8239)
+++ trunk/oggdsf/src/lib/core/ogg/libOOOgg/IFIFOBuffer.h	2004-11-21 06:47:53 UTC (rev 8240)
@@ -32,6 +32,10 @@
 #include "dllstuff.h"
 class LIBOOOGG_API IFIFOBuffer {
 public:
+	//Empty Constructor and destructor to ensure proper deletion
+	IFIFOBuffer(void)				{}
+	virtual ~IFIFOBuffer(void)		{}
+
 	virtual unsigned long read(unsigned char* outData, unsigned long inBytesToRead) = 0;
 	virtual unsigned long write(const unsigned char* inData, unsigned long inBytesToWrite) = 0;
 

Modified: trunk/oggdsf/src/lib/core/ogg/libOOOgg/INotifyArrival.h
===================================================================
--- trunk/oggdsf/src/lib/core/ogg/libOOOgg/INotifyArrival.h	2004-11-21 06:06:19 UTC (rev 8239)
+++ trunk/oggdsf/src/lib/core/ogg/libOOOgg/INotifyArrival.h	2004-11-21 06:47:53 UTC (rev 8240)
@@ -33,5 +33,8 @@
 class LIBOOOGG_API INotifyArrival
 {
 public:
+	//Empty Constructor and destructor to ensure proper deletion
+	INotifyArrival(void)				{}
+	virtual ~INotifyArrival(void)		{}
 	virtual void notifyArrival() = 0;
 };

Modified: trunk/oggdsf/src/lib/core/ogg/libOOOgg/INotifyComplete.h
===================================================================
--- trunk/oggdsf/src/lib/core/ogg/libOOOgg/INotifyComplete.h	2004-11-21 06:06:19 UTC (rev 8239)
+++ trunk/oggdsf/src/lib/core/ogg/libOOOgg/INotifyComplete.h	2004-11-21 06:47:53 UTC (rev 8240)
@@ -33,5 +33,10 @@
 class LIBOOOGG_API INotifyComplete
 {
 public:
+	//Empty Constructor and destructor to ensure proper deletion
+	INotifyComplete(void)					{}
+	virtual ~INotifyComplete(void)			{}
+
+
 	virtual void NotifyComplete() = 0;
 };

Modified: trunk/oggdsf/src/lib/core/ogg/libOOOgg/IOggCallback.h
===================================================================
--- trunk/oggdsf/src/lib/core/ogg/libOOOgg/IOggCallback.h	2004-11-21 06:06:19 UTC (rev 8239)
+++ trunk/oggdsf/src/lib/core/ogg/libOOOgg/IOggCallback.h	2004-11-21 06:47:53 UTC (rev 8240)
@@ -35,6 +35,11 @@
 class LIBOOOGG_API IOggCallback
 {
 public:
+	//Empty Constructor and destructor to ensure proper deletion
+	IOggCallback(void)					{}
+	virtual ~IOggCallback(void)			{}
+
+
 	//All callers to acceptOggPage give away their pointer
 	// to this function. All methods implementing this interface
 	// are responsible for deleting this page. All callers

Modified: trunk/oggdsf/src/lib/core/ogg/libOOOgg/IOggPackSource.h
===================================================================
--- trunk/oggdsf/src/lib/core/ogg/libOOOgg/IOggPackSource.h	2004-11-21 06:06:19 UTC (rev 8239)
+++ trunk/oggdsf/src/lib/core/ogg/libOOOgg/IOggPackSource.h	2004-11-21 06:47:53 UTC (rev 8240)
@@ -35,6 +35,10 @@
 class LIBOOOGG_API IOggPackSource
 {
 public:
+	//Empty Constructor and destructor to ensure proper deletion
+	IOggPackSource(void)					{}
+	virtual ~IOggPackSource(void)			{}
+
 	virtual OggPacket* getPacket(unsigned long inPacketNo) = 0;
 	virtual unsigned long numPackets() = 0;
 };

Modified: trunk/oggdsf/src/lib/core/ogg/libOOOgg/IStampedOggPacketSink.h
===================================================================
--- trunk/oggdsf/src/lib/core/ogg/libOOOgg/IStampedOggPacketSink.h	2004-11-21 06:06:19 UTC (rev 8239)
+++ trunk/oggdsf/src/lib/core/ogg/libOOOgg/IStampedOggPacketSink.h	2004-11-21 06:47:53 UTC (rev 8240)
@@ -36,6 +36,10 @@
 class LIBOOOGG_API IStampedOggPacketSink
 {
 public:
+	//Empty Constructor and destructor to ensure proper deletion
+	IStampedOggPacketSink(void)						{}
+	virtual ~IStampedOggPacketSink(void)			{}
+
 	//All callers to acceptStampedOggPacket give away their pointer
 	// to this function. All methods implementing this interface
 	// are responsible for deleting this packet. All callers



More information about the commits mailing list