[xiph-commits] r7580 - in trunk/theora: debian lib

Ralph Giles giles at xiph.org
Mon Aug 16 17:40:35 PDT 2004


On Mon, Aug 16, 2004 at 01:47:43AM -0700, thomasvs at motherfish-iii.xiph.org wrote:

> Modified:
>    trunk/theora/debian/Makefile.am
>    trunk/theora/lib/Makefile.am
> Log:
> remove files from Makefile.am in debian/ that aren't commited - I'd check
> who did this if there was a ChangeLog :) Please commit those files

$ svn blame -r 7579 Makefile.am
  3961       calc ## Process this file with automake to produce Makefile.in
  3961       calc 
  6932    ccheney EXTRA_DIST = changelog compat control copyright libtheora-dev.docs \
  6932    ccheney       libtheora-dev.install libtheora0.install rules

Looks like calc's alpha 3 packaging work from a few weeks ago.

This the the substance of my objection to ChangeLog. The information
is already in the repository commit messages, or should be, and it's
almost as easy to get at there; perhaps easier when the lists get long.
If you want to ship a ChangeLog file, that's another thing, but it
should be generated from the commit logs, not maintained in parallel.

IMHO. :)

> lib/Makefile.am: fix build and distcheck issues

BTW, laziness is allowed, but it's better to do mostly unrelated
things like this as two commits if you remember. Particularly 
something like the reformatting that's hard to review when mixed
with real changes.

 -r


More information about the commits mailing list