[xiph-commits] r7645 - in trunk/oggdsf: src/lib/codecs/flac/filters/dsfFLACDecoder src/lib/core/directshow/dsfAbstractAudioDecoder website

[illiminable at motherfish-iii.xiph.org]

Author: illiminable
Date: 2004-08-27 05:29:04 -0700 (Fri, 27 Aug 2004)
New Revision: 7645

Modified:
   trunk/oggdsf/src/lib/codecs/flac/filters/dsfFLACDecoder/FLACDecodeFilter.cpp
   trunk/oggdsf/src/lib/core/directshow/dsfAbstractAudioDecoder/AbstractAudioDecodeOutputPin.cpp
   trunk/oggdsf/website/index.html
Log:
* Fixed a bug in the flac decoder destructor which was dormant because of ref counting stuff.
* Added more bugs to the webpage.

Modified: trunk/oggdsf/src/lib/codecs/flac/filters/dsfFLACDecoder/FLACDecodeFilter.cpp
===================================================================
--- trunk/oggdsf/src/lib/codecs/flac/filters/dsfFLACDecoder/FLACDecodeFilter.cpp	2004-08-27 11:27:02 UTC (rev 7644)
+++ trunk/oggdsf/src/lib/codecs/flac/filters/dsfFLACDecoder/FLACDecodeFilter.cpp	2004-08-27 12:29:04 UTC (rev 7645)
@@ -58,7 +58,7 @@
 
 FLACDecodeFilter::~FLACDecodeFilter(void)
 {
-	DestroyPins();
+	//DestroyPins();
 	delete mFLACFormatBlock;
 }
 

Modified: trunk/oggdsf/src/lib/core/directshow/dsfAbstractAudioDecoder/AbstractAudioDecodeOutputPin.cpp
===================================================================
--- trunk/oggdsf/src/lib/core/directshow/dsfAbstractAudioDecoder/AbstractAudioDecodeOutputPin.cpp	2004-08-27 11:27:02 UTC (rev 7644)
+++ trunk/oggdsf/src/lib/core/directshow/dsfAbstractAudioDecoder/AbstractAudioDecodeOutputPin.cpp	2004-08-27 12:29:04 UTC (rev 7645)
@@ -158,12 +158,14 @@
 }
 
 HRESULT AbstractAudioDecodeOutputPin::DeliverEndFlush(void) {
+	CAutoLock locLock(mFilterLock);
 	//QUERY::: Locks ??
 	mDataQueue->EndFlush();
     return S_OK;
 }
 
 HRESULT AbstractAudioDecodeOutputPin::DeliverBeginFlush(void) {
+	CAutoLock locLock(mFilterLock);
 	//QUERY:: Locks ???
 	mDataQueue->BeginFlush();
     return S_OK;
@@ -171,6 +173,7 @@
 }
 
 HRESULT AbstractAudioDecodeOutputPin::CompleteConnect (IPin *inReceivePin) {
+	CAutoLock locLock(mFilterLock);
 	HRESULT locHR = S_OK;
 
 	//Here when another pin connects to us, we internally connect the seek delegate
@@ -189,7 +192,7 @@
 }
 
 HRESULT AbstractAudioDecodeOutputPin::BreakConnect(void) {
-
+	CAutoLock locLock(mFilterLock);
 	HRESULT locHR = CBaseOutputPin::BreakConnect();
 	ReleaseDelegate();
 	delete mDataQueue;

Modified: trunk/oggdsf/website/index.html
===================================================================
--- trunk/oggdsf/website/index.html	2004-08-27 11:27:02 UTC (rev 7644)
+++ trunk/oggdsf/website/index.html	2004-08-27 12:29:04 UTC (rev 7645)
@@ -78,6 +78,8 @@
 <br>
 <br>
 <b><u>Known issues.</u></b><br>
+	<li>FLAC seems to lose the first 1/2 second of audio if you stop then play again</li>
+	<li>Realised I broke the limited network streaming the previous version had. Don't try and stream anything. This is already resolved and will be in the next version coming soon.</li>
 	<li>Seeking is slightly less responsive in this latest version. Most noticable in speex.</li>
 	<li>Seeking very close to the end of speex or vorbis files, causes all audio to cease, requiring stop/play to resolve. Particularly noticable in small files, seems roughly 5 secs from end where this occurs.</li>
 	<li>There is no way to alter the audio encoding parameters, vorbis defaults to quality 0.3</li>