[xiph-cvs] cvs commit: ices/src mp3.c

Brendan brendan at xiph.org
Wed Mar 19 10:58:24 PST 2003



brendan     03/03/19 13:58:24

  Modified:    .        TODO
               src      mp3.c
  Log:
  File trimming code has been working very well for me for the last couple of
  days.

Revision  Changes    Path
1.5       +1 -6      ices/TODO

Index: TODO
===================================================================
RCS file: /cvs/ice/ices/TODO,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- TODO	16 Mar 2003 08:32:34 -0000	1.4
+++ TODO	19 Mar 2003 18:58:24 -0000	1.5
@@ -1,9 +1,4 @@
 * Improved error handling
 * Make the scripting engines, and vorbis and MP3 reencoding, run-time linkable
-* Investigate preventing chirps. These can happen if the previous file ended in
-  the middle of a frame. Possibly padding out to the frame length with NULL would fix it.
-  A really cheap hack would be to just dump the maximum possible frame size worth of
-  NULLs into the stream. In practice, this might not be any different since the
-  player should just ignore everything up until the next sync word.
 
-$Id: TODO,v 1.4 2003/03/16 08:32:34 brendan Exp $
+$Id: TODO,v 1.5 2003/03/19 18:58:24 brendan Exp $

<p><p>1.32      +1 -3      ices/src/mp3.c

Index: mp3.c
===================================================================
RCS file: /cvs/ice/ices/src/mp3.c,v
retrieving revision 1.31
retrieving revision 1.32
diff -u -r1.31 -r1.32
--- mp3.c	17 Mar 2003 04:45:03 -0000	1.31
+++ mp3.c	19 Mar 2003 18:58:24 -0000	1.32
@@ -17,7 +17,7 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
  *
- * $Id: mp3.c,v 1.31 2003/03/17 04:45:03 brendan Exp $
+ * $Id: mp3.c,v 1.32 2003/03/19 18:58:24 brendan Exp $
  */
 
 #include "definitions.h"
@@ -191,10 +191,8 @@
   if (off)
     ices_log_debug("Skipped %d bytes of garbage before MP3", off);
 
-#ifdef TRIM_FILE
   /* adjust file size for short frames */
   mp3_trim_file (source, &mh);
-#endif
 
   if (source->bitrate)
     ices_log_debug ("%s layer %s, %d kbps, %d Hz, %s", version_names[mh.version],

<p><p>--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'cvs-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.



More information about the commits mailing list