[xiph-cvs] cvs commit: net resolver.c

Brendan Cully brendan at xiph.org
Thu Mar 6 08:35:53 PST 2003



On Thursday, 06 March 2003 at 19:35, Michael Smith wrote:
> On Thursday 06 March 2003 13:36, Brendan Cully wrote:
> > On Thursday, 06 March 2003 at 13:17, Michael Smith wrote:
> > > Brendan <brendan at xiph.org> said:
> > > > NOTE to other users of the avl and net libs: If you want them to use
> > > > locking, you must #define USE_THREAD.
> > > >
> > > > I could flip this around so that it requires NO_THREAD to be defined in
> > > > order to turn off locking, if people think that's better.
> > >
> > > Yes. At least the net lib is broken without locking, so this is
> > > absolutely required - it should default to being in a fully functional
> > > state.
> >
> > It's broken in threaded apps, yes. Alright, I've flipped it around.
> 
> Thanks. (it's only actively broken in threaded apps. However, since libshout 
> claims - even if it's not written down - to be reentrant, it's logically 
> broken anyway)

When I added that code I also added thread library checking to libshout, so that
libshout would always set the define appropriately. So it wasn't actually broken in
libshout, but might have been in other apps that used the libs directly (not through
libshout). Anyway, moot point.
--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'cvs-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.



More information about the commits mailing list