[xiph-cvs] cvs commit: icecast/src main.c

Jack Moffitt jack at xiph.org
Tue May 21 07:54:19 PDT 2002



> > Yes. People want to be able to start as root (to bind to low ports, for
> > example), then setuid() to another user. So the setuid() has to occur
> > after binding the socket, but before the logs are opened (because people
> > don't want to be opening log files as root).
> 
> Why don't you always call the log functions, but have those output to
> stderr if the log isn't opened yet?  More robust and simpler :)

Agreed!

This already makes a large change to implement security on a subset of
platforms.  This is not a great idea for win32.  Using segher's
suggestion of making log_write() send output to stderr if the file isn't
opened will better allow win32 to do something useful.

jack.

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'cvs-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.



More information about the commits mailing list