[xiph-cvs] cvs commit: vorbis-tools/oggenc/man oggenc.1

[Michael Smith]

msmith      02/06/23 06:29:46

  Modified:    oggenc   oggenc.c
               oggenc/man oggenc.1
  Log:
  Fix #202 - behaviour of setting output filename based on title when no other
  explicit output filename was given was considered unintuitive and not useful.

Revision  Changes    Path
1.58      +4 -1      vorbis-tools/oggenc/oggenc.c

Index: oggenc.c
===================================================================
RCS file: /usr/local/cvsroot/vorbis-tools/oggenc/oggenc.c,v
retrieving revision 1.57
retrieving revision 1.58
diff -u -r1.57 -r1.58
--- oggenc.c	2002/06/18 14:15:07	1.57
+++ oggenc.c	2002/06/23 13:29:46	1.58
@@ -229,12 +229,15 @@
                         opt.namefmt_replace, artist, title, album, track,date,
                         genre);
                         }
+            /* This bit was widely derided in mid-2002, so it's been removed */
+            /*
                         else if(opt.title)
                         {
                                 out_fn = malloc(strlen(title) + 5);
                                 strcpy(out_fn, title);
                                 strcat(out_fn, ".ogg");
                         }
+            */
                         else if(infiles[i])
                         {
                                 /* Create a filename from existing filename, replacing extension with .ogg */
@@ -434,7 +437,7 @@
                 " files, or 32 bit IEEE floating point WAV. Files may be mono or stereo\n"
         " (or more channels) and any sample rate.\n"
                 " However, the encoder is only tuned for rates of 44.1 and 48 kHz and while\n"
-		" other rates will be accepted quality may be significantly degraded.\n"
+		" other rates will be acceptable, quality may be slightly degraded.\n"
                 " Alternatively, the --raw option may be used to use a raw PCM data file, which\n"
                 " must be 16bit stereo little-endian PCM ('headerless wav'), unless additional\n"
                 " parameters for raw mode are specified.\n"

<p><p>1.15      +1 -4      vorbis-tools/oggenc/man/oggenc.1

Index: oggenc.1
===================================================================
RCS file: /usr/local/cvsroot/vorbis-tools/oggenc/man/oggenc.1,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -r1.14 -r1.15
--- oggenc.1	2002/05/13 13:48:51	1.14
+++ oggenc.1	2002/06/23 13:29:46	1.15
@@ -89,10 +89,7 @@
 .B -o
 option (in the case of one file) or the
 .B -n
-option (in the case of several files). If neither of these options
-is given, but a title is (using
-.B -t
-), then the output filename will be title.ogg. Finally, if none of these
+option (in the case of several files). Finally, if none of these
 are available, the output filename will be the input filename with the
 extension (that part after the final dot) replaced with ogg, so file.wav
 will become file.ogg

<p><p><p>--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'cvs-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.