[xiph-cvs] cvs commit: icecast/src format_vorbis.c

Michael Smith msmith at xiph.org
Mon Jun 3 02:12:51 PDT 2002



msmith      02/06/03 02:12:51

  Modified:    src      format_vorbis.c
  Log:
  Fix for evil format string vulnerability - people, don't DO THIS!
  
  Fix from Emil Styrke <emil at lysator.liu.se>

Revision  Changes    Path
1.7       +4 -4      icecast/src/format_vorbis.c

Index: format_vorbis.c
===================================================================
RCS file: /usr/local/cvsroot/icecast/src/format_vorbis.c,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- format_vorbis.c	2002/05/03 15:04:56	1.6
+++ format_vorbis.c	2002/06/03 09:12:50	1.7
@@ -141,11 +141,11 @@
 
                                 /* put known comments in the stats */
                                 tag = vorbis_comment_query(&state->vc, "TITLE", 0);
-				if (tag) stats_event_args(self->mount, "title", tag);
-				else stats_event_args(self->mount, "title", "unknown");
+				if (tag) stats_event(self->mount, "title", tag);
+				else stats_event(self->mount, "title", "unknown");
                                 tag = vorbis_comment_query(&state->vc, "ARTIST", 0);
-				if (tag) stats_event_args(self->mount, "artist", tag);
-				else stats_event_args(self->mount, "artist", "unknown");
+				if (tag) stats_event(self->mount, "artist", tag);
+				else stats_event(self->mount, "artist", "unknown");
 
                                 /* don't need these now */
                                 ogg_stream_clear(&state->os);

<p><p><p>--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'cvs-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.



More information about the commits mailing list